Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in architecture compatibility data #56

Open
RunDevelopment opened this issue Mar 15, 2023 · 5 comments
Open

Fill in architecture compatibility data #56

RunDevelopment opened this issue Mar 15, 2023 · 5 comments
Labels
MVP Minimum Viable Product

Comments

@RunDevelopment
Copy link
Member

RunDevelopment commented Mar 15, 2023

This file is incomplete, I think. Check that the compatibility data is correct and fill in any gaps.

Compatibility means that any model of that architecture can be converted to the compatible platforms.

@joeyballentine
Copy link
Contributor

Can we call pytorch/onnx/ncnn frameworks and not architectures please

@RunDevelopment
Copy link
Member Author

RunDevelopment commented Mar 15, 2023

I called them platforms.

export type Platform = 'pytorch' | 'onnx' | 'ncnn';

Archs are e.g. ESRGAN. Or in general, the architecture field of models.

@joeyballentine
Copy link
Contributor

You used architecture in the issue post

@RunDevelopment
Copy link
Member Author

Fixed.

@joeyballentine joeyballentine added the MVP Minimum Viable Product label Mar 22, 2023
@RunDevelopment
Copy link
Member Author

With #235, we just need to test EDSR (SRResNet), which we currently can't do because chainner doesn't support it.

Also, we (speak @theflyingzamboni) are currently working on NCNN for SPSR. This should be possible, but there seems to be an issue with our conversion code. See our private conversation on discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MVP Minimum Viable Product
Projects
None yet
Development

No branches or pull requests

2 participants