Skip to content

Remove the OMC API functions #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adeas31 opened this issue Apr 30, 2025 · 1 comment
Open

Remove the OMC API functions #276

adeas31 opened this issue Apr 30, 2025 · 1 comment
Milestone

Comments

@adeas31
Copy link
Member

adeas31 commented Apr 30, 2025

Write now we have created wrapper functions for each OMC API. It very difficult to keep track of API changes. OMPython is not directly linked with OMC so it is not possible to generate these wrapper functions automatically.

I suggest we remove these wrapper functions and clean up the code. The user can still call OMC API using sendExpression.

@adeas31 adeas31 added this to the 3.8.0 milestone Apr 30, 2025
@syntron
Copy link
Contributor

syntron commented May 3, 2025

PR #282 prepares this; it removes all dependencies on OMCSessionBase - currently it keeps the code alive as OMCSessionCmd but if needed, this part can be removed

I have no feelings regarding this as I do not use the interface provided here ...

The main point to keep it would be that besides 4 function it is quite simple code now. The functions are:

  • getClassComment() - pyparsing.ParseException should be handled in sendExpression()
  • getParameterNames() - additional check for KeyError needed?
  • getParameterValue() - pyparsing.ParseException should be handled in sendExpression()
  • getNthComponentModification() - ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants