-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CTranslate2 wrapping in translation_server #2001
Comments
After reviewing the code, here's what could be improved:
|
I did not realize that the translation method is inside a critical section. Note this is not needed for CTranslate2: the translation and model loading/unloading are fully thread safe. So removing the critical section for CTranslate2 can improve the scalability of the server for CPU translations with |
@francoishernandez @pltrdy do you recall why this #1108 was introduced ? |
I think that in the translation server loading/unloading and even running a model was not thread safe. I don't know anything about CTranslate 2 tho, so I can't tell how they differ |
"Good evening. I have an issue. When I run the command ( |
https://forum.opennmt.net/t/ctranslate2-on-opennmt-py-server/4175/8
The text was updated successfully, but these errors were encountered: