From 85ddbfc6506bba3851885f18a186abd691653f36 Mon Sep 17 00:00:00 2001
From: Nell Hardcastle <nell@dev-nell.com>
Date: Fri, 8 Nov 2024 14:39:29 -0800
Subject: [PATCH] tests(app): Integration test UpdatePermissions component
 based on input type

---
 .../update-permissions.spec.jsx.snap          |  17 ++-
 .../__tests__/update-permissions.spec.jsx     | 100 ++++++++++++++++--
 2 files changed, 107 insertions(+), 10 deletions(-)

diff --git a/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/__snapshots__/update-permissions.spec.jsx.snap b/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/__snapshots__/update-permissions.spec.jsx.snap
index a7e905e71..5c4f721d1 100644
--- a/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/__snapshots__/update-permissions.spec.jsx.snap
+++ b/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/__snapshots__/update-permissions.spec.jsx.snap
@@ -1,6 +1,19 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
-exports[`UpdateDatasetPermissions mutation > renders with default props 1`] = `
+exports[`UpdateDatasetPermissions mutation > calls UPDATE_ORCID_PERMISSIONS when clicked with an ORCID 1`] = `
+<DocumentFragment>
+  <button
+    aria-label="Share"
+    class="on-button on-button--small on-button--primary  btn-modal-action"
+    role="button"
+    type="button"
+  >
+    Share
+  </button>
+</DocumentFragment>
+`;
+
+exports[`UpdateDatasetPermissions mutation > calls UPDATE_PERMISSIONS when clicked with an email address 1`] = `
 <DocumentFragment>
   <button
     aria-label="Share"
@@ -13,7 +26,7 @@ exports[`UpdateDatasetPermissions mutation > renders with default props 1`] = `
 </DocumentFragment>
 `;
 
-exports[`UpdateDatasetPermissions mutation > renders with typical props 1`] = `
+exports[`UpdateDatasetPermissions mutation > renders with default props 1`] = `
 <DocumentFragment>
   <button
     aria-label="Share"
diff --git a/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/update-permissions.spec.jsx b/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/update-permissions.spec.jsx
index fdeac5ff5..b5d87c1e2 100644
--- a/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/update-permissions.spec.jsx
+++ b/packages/openneuro-app/src/scripts/dataset/mutations/__tests__/update-permissions.spec.jsx
@@ -1,7 +1,44 @@
 import React from "react"
-import { render } from "@testing-library/react"
+import { fireEvent, render, screen, waitFor } from "@testing-library/react"
 import { MockedProvider } from "@apollo/client/testing"
-import { isValidOrcid, UpdateDatasetPermissions } from "../update-permissions"
+import {
+  isValidOrcid,
+  UPDATE_ORCID_PERMISSIONS,
+  UPDATE_PERMISSIONS,
+  UpdateDatasetPermissions,
+} from "../update-permissions"
+
+function permissionMocksFactory(
+  updatePermissionsCalled,
+  updateOrcidPermissionsCalled,
+) {
+  return [
+    {
+      request: {
+        query: UPDATE_PERMISSIONS,
+
+        variables: {
+          datasetId: "ds000005",
+          userEmail: "test@example.com",
+          level: "ro",
+        },
+      },
+      newData: updatePermissionsCalled,
+    },
+    {
+      request: {
+        query: UPDATE_ORCID_PERMISSIONS,
+
+        variables: {
+          datasetId: "ds000005",
+          userOrcid: "0000-0002-1694-233X",
+          level: "ro",
+        },
+      },
+      newData: updateOrcidPermissionsCalled,
+    },
+  ]
+}
 
 describe("UpdateDatasetPermissions mutation", () => {
   it("renders with default props", () => {
@@ -12,18 +49,65 @@ describe("UpdateDatasetPermissions mutation", () => {
     )
     expect(asFragment()).toMatchSnapshot()
   })
-  it("renders with typical props", () => {
+  it("calls UPDATE_PERMISSIONS when clicked with an email address", async () => {
+    const updatePermissionsCalled = vi.fn()
+    const updateOrcidPermissionsCalled = vi.fn()
+    const mocks = permissionMocksFactory(
+      updatePermissionsCalled,
+      updateOrcidPermissionsCalled,
+    )
+    const done = vi.fn()
     const { asFragment } = render(
-      <MockedProvider>
+      <MockedProvider mocks={mocks} addTypename={false}>
         <UpdateDatasetPermissions
           datasetId="ds000005"
-          userEmail="test@example.com"
-          access="ro"
-          done={vi.fn()}
+          userIdentifier="test@example.com"
+          metadata="ro"
+          done={done}
         />
       </MockedProvider>,
     )
-    expect(asFragment()).toMatchSnapshot()
+    const fragment = asFragment()
+    expect(fragment).toMatchSnapshot()
+    // Try clicking the button and make sure the right mutation runs
+    const button = screen.getByRole("button")
+    await fireEvent.click(button)
+    // Make sure it ran at all
+    await waitFor(() => expect(done).toHaveBeenCalled())
+    // Verify the expected query ran
+    await waitFor(() => expect(updatePermissionsCalled).toHaveBeenCalled())
+    await waitFor(() =>
+      expect(updateOrcidPermissionsCalled).not.toHaveBeenCalled()
+    )
+  })
+  it("calls UPDATE_ORCID_PERMISSIONS when clicked with an ORCID", async () => {
+    const updatePermissionsCalled = vi.fn()
+    const updateOrcidPermissionsCalled = vi.fn()
+    const mocks = permissionMocksFactory(
+      updatePermissionsCalled,
+      updateOrcidPermissionsCalled,
+    )
+    const done = vi.fn()
+    const { asFragment } = render(
+      <MockedProvider mocks={mocks} addTypename={false}>
+        <UpdateDatasetPermissions
+          datasetId="ds000005"
+          userIdentifier="0000-0002-1694-233X"
+          metadata="ro"
+          done={done}
+        />
+      </MockedProvider>,
+    )
+    const fragment = asFragment()
+    expect(fragment).toMatchSnapshot()
+    // Try clicking the button and make sure the right mutation runs
+    const button = screen.getByRole("button")
+    await fireEvent.click(button)
+    // Make sure it ran at all
+    await waitFor(() => expect(done).toHaveBeenCalled())
+    // Verify the expected query ran
+    await waitFor(() => expect(updatePermissionsCalled).not.toHaveBeenCalled())
+    await waitFor(() => expect(updateOrcidPermissionsCalled).toHaveBeenCalled())
   })
   describe("isValidOrcid", () => {
     it("matches typical ORCID strings", () => {