Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty commits with the "author ownership" upon editing dataset_description.json #3257

Open
yarikoptic opened this issue Dec 17, 2024 · 0 comments
Labels

Comments

@yarikoptic
Copy link
Contributor

What went wrong?

I am looking at git history of changes @jungheejung did on ds005256 (yet to be published).

history looks a little odd in that some of the changes of content in dataset description, commit author is Git Worker <[email protected]> are followed by empty commits with @jungheejung's name:

git log --stat --format=fuller openneuro-git/main | head -n 80
commit c88d225032f9fd2811dc5dbb7e084f46a3f6caa6
Author:     Heejung Jung <[email protected]>
AuthorDate: Wed Nov 27 06:41:58 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:42:00 2024 +0000

    [OpenNeuro] Recorded changes

commit 333f879fc337ea765efd7876b059702a44fbf02f
Author:     Git Worker <[email protected]>
AuthorDate: Wed Nov 27 06:41:57 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:41:58 2024 +0000

    [OpenNeuro] Recorded changes

 dataset_description.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

commit aa56dd02b4ded4170d39a167a47761c86d198309
Author:     Heejung Jung <[email protected]>
AuthorDate: Wed Nov 27 06:39:19 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:39:20 2024 +0000

    [OpenNeuro] Recorded changes

commit cf783ccee04c3bbe95686fa02d117ae3417f0b02
Author:     Git Worker <[email protected]>
AuthorDate: Wed Nov 27 06:39:18 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:39:19 2024 +0000

    [OpenNeuro] Recorded changes

commit 0d1a4392463c2ae9a1ed7e4d86384ca50ba04ddd
Author:     Heejung Jung <[email protected]>
AuthorDate: Wed Nov 27 06:39:17 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:39:18 2024 +0000

    [OpenNeuro] Recorded changes

commit 8d5fc90b116375cdd1ff95c4dde49a1fe6a058b8
Author:     Git Worker <[email protected]>
AuthorDate: Wed Nov 27 06:39:09 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Wed Nov 27 06:39:17 2024 +0000

    [OpenNeuro] Recorded changes

 dataset_description.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

commit 01c2deba8f49959ad9165de9f346f46ea6ff2d96
Author:     Heejung Jung <[email protected]>
AuthorDate: Fri Nov 22 16:48:59 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Fri Nov 22 16:49:05 2024 +0000

    [OpenNeuro] Recorded changes

commit ae54387e09407318eb3ee3b2caff83b0640d26b0
Author:     Git Worker <[email protected]>
AuthorDate: Fri Nov 22 16:48:55 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Fri Nov 22 16:48:59 2024 +0000

    [OpenNeuro] Recorded changes

 dataset_description.json | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

commit d5c11698610b5a61c4be8e63bed5b0de3a6ebb20
Author:     Heejung Jung <[email protected]>
AuthorDate: Fri Nov 22 16:48:42 2024 +0000
Commit:     Git Worker <[email protected]>
CommitDate: Fri Nov 22 16:48:45 2024 +0000

    [OpenNeuro] Recorded changes

it seems that many of those commits are not needed and ideally should be avoided. I guess also commits with actual changes should be the ones with @hungheejung as the author

Expected behavior

no empty commits

How to reproduce

N/A

Desktop

N/A

Phone

  • Device:
  • OS:
  • Browser:
  • Version:

Additional information

No response

@yarikoptic yarikoptic added the bug label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant