Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: ARM (Azure) template deployment #71

Open
sameersegal opened this issue Jun 8, 2024 · 10 comments
Open

[Feature Request]: ARM (Azure) template deployment #71

sameersegal opened this issue Jun 8, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@sameersegal
Copy link
Collaborator

sameersegal commented Jun 8, 2024

Is your feature request related to a problem? Please describe.

We need an ARM template-based deployment that works as easily as the following:

$ az login
$ az account set --subscription <Subscription ID>
$ az group create --name MyResourceGroup --location eastus
$ az deployment group create --resource-group MyResourceGroup --template-file template.json --parameters parameters.json

Describe the solution you'd like

We can leverage the public images for the containers. e.g. opennyaiin/jugalbandi-manager:api-latest
We need to run an SQL script for DB upgrade / initialization.
We assume Azure OpenAI is configured before and we have the relevant keys. Similarly Bhashini keys are inputed

Refer to this ChatGPT conversation: https://chatgpt.com/share/c960b010-2ad8-48f4-b0df-5301c78922a9

Later:
We need to use AKS (kubernetes) for deployment
We need to use Managed Identity (as per latest guidelines) instead of using Storage Account / EventHubs keys

Additional context

No response

@sameersegal sameersegal added the enhancement New feature or request label Jun 8, 2024
@sameersegal
Copy link
Collaborator Author

sameersegal commented Jun 17, 2024

  • Give contributor access to AK, SS on OpenNyAI subscription
  • Create individual ARM templates for each of the resources
  • Sequence (EventHub, Postgres, Storage Account and then containers) and merge resources
  • Script for actions
    • DB upgrade
    • Build react (frontend) and deploy to Azure Storage Account

@sameersegal
Copy link
Collaborator Author

Discussion with Azure folks:

We are creating a Solution Template since we are not interested in charging. It's a give away without retaining any rights as the publisher.

Refer to this example: https://github.com/Azure/Commercial-Marketplace-SaaS-Accelerator-Offer

Please note that if you need to execute scripts that also run AZ CLI, you probably will have to create a user-assigned managed identity and assign role assignments on the resources/resource group so that it has sufficient access to run the commands

The solution template linked above also imports a schema so that would also help I believe

Once you have ARM templates ready, use ARM TTK (toolkit) to validate

And then publish and test in your own subscription using a Service Catalog:

https://learn.microsoft.com/en-us/azure/azure-resource-manager/managed-applications/publish-service-catalog-app?tabs=azure-powershell

@KaranrajM
Copy link
Contributor

@wi0lono Is the issue good to close? Please provide status

@Lekhanrao
Copy link
Collaborator

@DevvStrange, any update here?

@DevvStrange
Copy link
Contributor

Hi @wi0lono, as discussed could you please add the latest updates here and the scope of improvement required as in to take this further.

@Lekhanrao
Copy link
Collaborator

Waiting for Atarv from Microsoft for inputs

@wi0lono
Copy link
Collaborator

wi0lono commented Oct 29, 2024

Hi, sorry for the late update!
There is an almost complete azure template deployment in the deployments/azure/templates folder. There is a README file with instructions on how to deploy.

What remains incomplete is

  1. mainTemplate.json is missing a "channel" container template
  2. Instructions and templates to set up the frontend of the manager with a custom URL, which would be needed for a production setup (You might want to take the instructions for certificate setup from here.

Please let me know if you have any other questions.

@Lekhanrao
Copy link
Collaborator

@DevvStrange, Hi Arun, would you be working on the incomplete items mentioned by Atharv?

@DevvStrange
Copy link
Contributor

Yes Lekha, I will take this up further.

@Lekhanrao
Copy link
Collaborator

@DevvStrange any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants