Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio system: background music AND random Sfx #88

Open
uberlinuxguy opened this issue Dec 4, 2021 · 3 comments
Open

Audio system: background music AND random Sfx #88

uberlinuxguy opened this issue Dec 4, 2021 · 3 comments

Comments

@uberlinuxguy
Copy link
Member

currently, the background player only plays either a random sfx or music. Music should always be playing if enabled. Random sfx should play under music, not instead of.

@uberlinuxguy
Copy link
Member Author

Taking a quick-ish look at the audio code,

it initializes 32 mixer channels. It's not clear it uses all of them.

The random "game sfx" shouldn't play as music.

Thought:

  • separate samples and game sfx into channels for sound types
  • music only plays music.

Channel list:

  • item collection
  • "Jim" comments
  • game sfx
  • weapon sounds (all 4 energy weapons.)
  • missle sounds (dumb, guided, swarm, mines)
  • ship sounds (shields, after burner, counting, emp)
  • music

By the look of it 8 channels should suffice.
Would need a way to tag each sample with what channel to play on. Not sure if this is being done at the moment, needs more digging

The audio code is also a hot mess of unused stuff. There is an open ticket for cleaning this up somewhere.

@CrazySpence
Copy link
Member

I don't think i've ever heard it play a SFX not since before 0.2 anyways, heres a couple janky short transition songs that are a few seconds long though

@uberlinuxguy
Copy link
Member Author

the short stuff is what I think is the game sfx...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants