Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

understand display image size #2

Open
eroux opened this issue Jan 6, 2023 · 9 comments
Open

understand display image size #2

eroux opened this issue Jan 6, 2023 · 9 comments
Assignees

Comments

@eroux
Copy link
Contributor

eroux commented Jan 6, 2023

  1. if the image size can be configured, it should be a bit bigger
  2. in any case, the processing should produce images that are the exact size that prodigy requires
@eroux
Copy link
Contributor Author

eroux commented Jan 6, 2023

Note that "height" and "width" keys are accepted in the image_manual thing that we might want to use for that purpose

@ngawangtrinley
Copy link
Contributor

@ta4tsering what's the status with this?

@ta4tsering
Copy link
Contributor

@Zakongjampa is handling this issue, since I was handling the image sampling for the layout analysis

@kaldan007
Copy link
Contributor

@Zakongjampa any update

@Zakongjampa
Copy link
Contributor

The default max-width of the prodigy image container is only 657px. I have increased the max-width of the container with up to 2000px, which makes the image larger.

Before the update

before

After the update

after

@eroux
Copy link
Contributor Author

eroux commented Jan 25, 2023

thanks! @kaldan007 can you check with the annotators what screen resolution / size they have on average so that we can produce images of a good size?

@kaldan007
Copy link
Contributor

ok. i will reach out to our freelancer manager to get an idea

@kaldan007
Copy link
Contributor

@eroux one team is having screen size of average 21 inch and other one 14inch(most are using laptops varying from 15inch to 13inch)

@eroux
Copy link
Contributor Author

eroux commented Jan 27, 2023

Interesting, thanks!

Generally speaking I think a 13" laptop will not be ideal for the jib but we can try

It would be helpful to have their screen width in px but for now let's assume that the value of 2000px works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants