-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove /lib/rc/tmp creation from meson script #650
Conversation
Why was this directory created in the first place? It was introduced with d6622a1 |
It is apparently for a piece of code that no longer exist. There don't seem to be any part of the code that refers to this directory... The reason why I raise this with some urgency is due to Debian maintainers having some issue maintaining the openrc package due to this directory. |
This needs to be explained in the commit message. |
It is apparently for a piece of code that no longer exist. There don't seem to be any part of the code referring to this directory (anymore, if there was).
@thesamesam can we do it in the merge commit message? |
Also I can not find anything referring to this directory. 391d12d removed c0fd1b4 added that line when moving it from 0af7d5b seems to have removed the use of it. a010d0b mentions it again, seems to been introduced with 5af58b4. It looks like it used to be a tmpfs mount to store the deptree and similar. I'd say its save to remove. |
No, we don't do merge commits, and the person submitting a PR should really be justifying their change before it gets merged? |
@timkenhan |
6781b82
to
de36045
Compare
@ncopa thanks! |
i've updated the commit message. lemme know if there's anything else i need to do |
No description provided.