openrc-shutdown: broadcast: avoid double fclose #707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
force-pushed
the
bug923326
branch
2 times, most recently
from
4baacad
to
eddb17b
Compare
N-R-K
approved these changes
May 22, 2024
N-R-K
suggested changes
May 23, 2024
| if (fd >= 0) | ||
| /* | ||
| * It is possible we got here because fputs or fflush got | ||
| * interrupted by SIGALARM. Close the file descriptor first to |
There was a problem hiding this comment.
Doesn't this result in a double close of fd?
If blocking is the issue why not make the fd non-blocking?
There was a problem hiding this comment.
Yes, it does result in a double close. I should update the summary: the bug is a double fclose, since that causes a double free.
The fd is already non-blocking, but the original author doesn't trust the kernel to respect that apparently. The whole SIGALARM path should really be stripped out and simplified.
Initialize fd and tp to known invalid values, and reset them after calling close/fclose. This is necessary since these are decleared as static variables. Note the close will will likely still be called twice: we close fd before tp to avoid any buffered writes. Bug: https://bugs.gentoo.org/923326 Signed-off-by: Mike Gilbert <[email protected]>
floppym
changed the title
|
Closing in favor of #709. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize fd and tp to known invalid values, and reset them after
calling close/fclose. This is necessary since these are decleared as
static variables.
Note the close will will likely still be called twice: we close fd
before tp to avoid any buffered writes.
Bug: https://bugs.gentoo.org/923326