librc, rc, supervise-daemon: Repace hardcoded paths with function calls. #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navi-desu
force-pushed
the
dynamic-paths
branch
2 times, most recently
from
089f500
to
0a520f8
Compare
|
removed the side effect of the change, now only the sysconfdir is checked like before. also renamed the new api functions to be more inline with how we name directory variables. rc_scriptdirs() holds a null terminated list of strings to the base directories that init.d and conf.d exist (PKG_PREFIX, SYSCONFDIR, LOCAL_PREFIX) |
navi-desu
force-pushed
the
dynamic-paths
branch
from
0a520f8
to
7c0e81a
Compare
navi-desu
force-pushed
the
dynamic-paths
branch
from
7c0e81a
to
3f3eeb9
Compare
This lays the groundwork for other features like user services, or a different root prefix, by allowing us to change where openrc looks up for files at runtime.
navi-desu
force-pushed
the
dynamic-paths
branch
from
3f3eeb9
to
9e6269e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for other features like user services, or a different root prefix, by allowing us to change where openrc looks up for files at runtime.
As a side effect of this change, now all sysconfdirs (aka RC_PKG_PREFIX and RC_LOCAL_PREFIX) are checked for configuration files (rc.conf and rc.conf.d).
This is the first of three patches for openrc-user support.
I am unsure about the api for rc_sysconf_dir, however, an RC_STRINGLIST would be more idiomatic to the codebase, but at the same time, the current NULL terminated double pointer allows for avoiding allocations when not necessary