Merge pull request #237 from jan-cerny/pylint_error

Fix pylint problems

openscap_report/dataclasses/dataclasses.py

@@ -446,7 +446,7 @@ def _field_init(f, frozen, globals, self_name):
             if f.default is MISSING:
                 # There's no default, just do an assignment.
                 value = f.name
-            elif f.default is not MISSING:
+            else:
                 globals[default_name] = f.default
                 value = f.name
         else:

tests/unit_tests/test_shared_static_methods_of_parser.py

@@ -22,29 +22,29 @@ def test_get_unique_id_in_dict(object_, dict_):
 
 
 @pytest.mark.unit_test
-@pytest.mark.parametrize("element, expect_key", [
+@pytest.mark.parametrize("elem, expect_key", [
     (etree.Element("xml_element"), "xml_element"),
     (etree.Element("{}xml_element"), "xml_element"),
     (etree.Element("{NAME_SPACE}xml_element"), "xml_element"),
 ])
-def test_get_key_of_xml_element(element, expect_key):
-    key_element = SharedStaticMethodsOfParser.get_key_of_xml_element(element)
+def test_get_key_of_xml_element(elem, expect_key):
+    key_element = SharedStaticMethodsOfParser.get_key_of_xml_element(elem)
     assert key_element == expect_key
 
 
-@pytest.fixture
-def element(request):
+@pytest.fixture(name="parametrized_element")
+def fixture_parametrized_element(request):
     e = etree.Element("xml_element")
     e.text = request.param
     return e
 
 
 @pytest.mark.unit_test
-@pytest.mark.parametrize("element, expected_text", [
+@pytest.mark.parametrize("parametrized_element, expected_text", [
     (None, ""),
     ("", ""),
     ("abcd", "abcd"),
-], indirect=["element"])
-def test_get_text_of_xml_element(element, expected_text):
-    text = SharedStaticMethodsOfParser.get_text_of_xml_element(element)
+], indirect=["parametrized_element"])
+def test_get_text_of_xml_element(parametrized_element, expected_text):
+    text = SharedStaticMethodsOfParser.get_text_of_xml_element(parametrized_element)
     assert text == expected_text