Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_lib_version is broken on new versions of FFmpeg #947

Open
anatoly-romanov opened this issue Dec 20, 2023 · 2 comments
Open

parse_lib_version is broken on new versions of FFmpeg #947

anatoly-romanov opened this issue Dec 20, 2023 · 2 comments

Comments

@anatoly-romanov
Copy link

anatoly-romanov commented Dec 20, 2023

Newer FFmpeg releases have their version information headers split into version_major.h and version.h. This causes the parse_lib_version macro from cmake/Modules/FindFFmpeg.cmake to parse them incorrectly. For example FFMPEG_AVFORMAT_VERSION is parsed as 20.100 instead of 60.20.100. This leads to various errors when trying to build libopenshot.

@marillat
Copy link

marillat commented Apr 5, 2024

Also broken in latest ffmpeg 7.0

@jonoomph
Copy link
Member

jonoomph commented May 9, 2024

Yes, thanks! OpenShot needs some major work to integrate the newest versions of FFmpeg. This is on our roadmap, and hopefully we can get to it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants