Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash route: Return an error if no content-type was provided #113

Open
ostcar opened this issue Nov 14, 2021 · 0 comments
Open

Hash route: Return an error if no content-type was provided #113

ostcar opened this issue Nov 14, 2021 · 0 comments
Milestone

Comments

@ostcar
Copy link
Member

ostcar commented Nov 14, 2021

If you use the hash-route in a wrong way, for example when no content-type is set or wrong request data is provided, the route returns with success=true and am empty hash. I think it would be better if there was an error message

$ curl --header "content-type: application/json" localhost:9004/internal/auth/hash -d '{"to_hash":"admin"}'
{"message":"Action handled successfully","success":true,"hash":""}

$ curl localhost:9004/internal/auth/hash -d '{"toHash":"admin"}'
{"message":"Action handled successfully","success":true,"hash":""}
@GabrielInTheWorld GabrielInTheWorld added this to the 4.0 Release milestone Jan 31, 2022
@jsangmeister jsangmeister modified the milestones: 4.0 Release, 4.1 Release Dec 12, 2022
@jsangmeister jsangmeister modified the milestones: 4.1, 4.2 Dec 12, 2023
@Elblinator Elblinator modified the milestones: 4.2, 4.3 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants