Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty string usage if translations are missing #2697

Open
Elblinator opened this issue Oct 22, 2024 · 0 comments
Open

Fix empty string usage if translations are missing #2697

Elblinator opened this issue Oct 22, 2024 · 0 comments
Labels
Milestone

Comments

@Elblinator
Copy link
Member

Describe the bug
If the translations from a string are missing and the strings are delivered by the backend then empty strings are used to translate the string

How to Reproduce
Two examples:

  1. Set your browser default language to Spanish

  2. In the es.po file remove the translated string from "You are receiving this email because you have requested a new password for your OpenSlides account..." and from "Email subject"

  3. Send yourself a reset email the subject line and the content are empty

  4. from the es.po remove the translation from "Delegates"

  5. Create a new meeting in spanish

  6. The following Error is thrown Error: data.name must be longer than or equal to 1 characters

Expected behavior
If the translations in the translation file are missing (aka. are empty strings) then the english strings should be used

@Elblinator Elblinator added the bug label Oct 22, 2024
@Elblinator Elblinator added this to the 4.2 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant