Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTF] Do not request non existing Fields #2600

Closed
ostcar opened this issue Aug 4, 2023 · 1 comment
Closed

[RTF] Do not request non existing Fields #2600

ostcar opened this issue Aug 4, 2023 · 1 comment
Assignees
Milestone

Comments

@ostcar
Copy link
Member

ostcar commented Aug 4, 2023

Currently, the Client is requesting fields from the autoupdate-service, that do not exist. For example:

additionalFields: [`origin_id`, `origin_meeting_id`, `derived_motion_ids`]

There are probably many more.

The autoupdate-service will handle unknown fields as invalid fields in the rtf-branch as soon as this PR is merged: OpenSlides/openslides-autoupdate-service#738

There are two ways we could handle this. The autoupate-service could ignore invalid fields (and unknown fields). Or you could remove the non existing fields from the client requests.

I would prefer that the client would not request non existing fields, since there is no reason to request a field, that does not exist. I would say, that requesting a non existing field is always a bug. If the autoupdate-service rejects requests with unknown fields, it will probably help to find this bugs. But I can understand, if you don't want to check all subscriptions now.

Please tell me how you want to solve this.

I labeled this as high, because it blockes the PR in the autoupdate-service from being merged.

@jsangmeister
Copy link
Contributor

I agree, we should remove these fields from the subscriptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants