You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two ways we could handle this. The autoupate-service could ignore invalid fields (and unknown fields). Or you could remove the non existing fields from the client requests.
I would prefer that the client would not request non existing fields, since there is no reason to request a field, that does not exist. I would say, that requesting a non existing field is always a bug. If the autoupdate-service rejects requests with unknown fields, it will probably help to find this bugs. But I can understand, if you don't want to check all subscriptions now.
Currently, the Client is requesting fields from the autoupdate-service, that do not exist. For example:
openslides-client/client/src/app/site/pages/meetings/pages/motions/motions.subscription.ts
Line 58 in 314a961
openslides-client/client/src/app/site/pages/meetings/pages/motions/motions.subscription.ts
Line 78 in 314a961
openslides-client/client/src/app/site/pages/organization/pages/dashboard/dashboard.subscription.ts
Line 15 in 314a961
There are probably many more.
The autoupdate-service will handle unknown fields as invalid fields in the rtf-branch as soon as this PR is merged: OpenSlides/openslides-autoupdate-service#738
There are two ways we could handle this. The autoupate-service could ignore invalid fields (and unknown fields). Or you could remove the non existing fields from the client requests.
I would prefer that the client would not request non existing fields, since there is no reason to request a field, that does not exist. I would say, that requesting a non existing field is always a bug. If the autoupdate-service rejects requests with unknown fields, it will probably help to find this bugs. But I can understand, if you don't want to check all subscriptions now.
Please tell me how you want to solve this.
I labeled this as high, because it blockes the PR in the autoupdate-service from being merged.
The text was updated successfully, but these errors were encountered: