You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As planned and currently done in OpenSlides/openslides-proxy#4 the proxy will start responding with 413 when request payloads exceed (per default 250M) in size.
The client should handle this appropriately.
Imo a short message a snack box should suffice.
Also we could include the REQUEST_BODY_MAX_SIZE env var to the client. This way the client can also communicate the current limit to the user.
Alternatively we might want to have a statically-served-by-the-proxy route to get the limit. This would have to advantage of having to only restart the proxy when changing the limit.
The text was updated successfully, but these errors were encountered:
Alternatively we might want to have a statically-served-by-the-proxy route to get the limit. This would have to advantage of having to only restart the proxy when changing the limit.
I'm not a fan of this. How often will this limit get changed? Probably very seldom. Sending a request to get that information seems overkill, especially since 1) every client has to do that 2) every x seconds/minutes to check if the limit changed, or otherwise the feature won't work as intended.
Alternatively we might want to have a statically-served-by-the-proxy route to get the limit. This would have to advantage of having to only restart the proxy when changing the limit.
I'm not a fan of this. How often will this limit get changed? Probably very seldom. Sending a request to get that information seems overkill, especially since 1) every client has to do that 2) every x seconds/minutes to check if the limit changed, or otherwise the feature won't work as intended.
I see your point, this is probably not the right way.
Another alternative would be to set an http header on the response conveying the limit. I think that should be a good way of doing it.
As planned and currently done in OpenSlides/openslides-proxy#4 the proxy will start responding with 413 when request payloads exceed (per default 250M) in size.
The client should handle this appropriately.
Imo a short message a snack box should suffice.
Also we could include the
REQUEST_BODY_MAX_SIZE
env var to the client. This way the client can also communicate the current limit to the user.Alternatively we might want to have a statically-served-by-the-proxy route to get the limit. This would have to advantage of having to only restart the proxy when changing the limit.
The text was updated successfully, but these errors were encountered: