Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion and projection of it with wrong line numbers (amendment vs. change recom. at same position) #2903

Closed
Tracked by #2956
MSoeb opened this issue Oct 17, 2023 · 2 comments
Assignees
Labels
bug high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Milestone

Comments

@MSoeb
Copy link

MSoeb commented Oct 17, 2023

Description: If a motion has a change recommendation and an amendment at the same paragraph position, the line numbering in motion view and in the projection is wrong. As you see in the first image, the line of the second change (her change recommendation) starts with 2 and in the second image - the projection - with 6. This is wrong.

Motion view:
Screenshot_20231017_145009

Projection:
Screenshot_20231017_143415

Reproduction:

  1. open a meeting
  2. open motions
  3. create a motion with one paragraph with a few lines.
  4. create a change recommendation and accept it
  5. create an amendment which changes the whole paragraph and change state to accepted (not sure if needed, but it shows it quite well)
  6. now both changes should be in conflict
  7. project the motion in diff version

What should happen:
The lines of each paragraph should start at number 1, because the content of the changes is in conflict and did not follow each other, which would justify an ongoing numbering.

@MSoeb MSoeb added the bug label Oct 17, 2023
@MSoeb MSoeb added this to the 4.1 milestone Oct 17, 2023
@MSoeb MSoeb changed the title Motion projection with wrong line numbers (amendment vs. change recom. at same position) Motion and projection of it with wrong line numbers (amendment vs. change recom. at same position) Oct 17, 2023
@Elblinator Elblinator added the needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time label Oct 27, 2023
@Elblinator
Copy link
Member

The behaviour of the projection potentially changed due to the Issue #2880, please verify that the buggy behaviour is still there
Additionally:
Just to be clear: If one paragraph was changed two times by an amendment or a change recommendation and these changes are in conflict to each other. Then the whole paragraph should be displayed two times in the projection. Not just the conflicting lines?
@MSoeb @emanuelschuetze

@MSoeb
Copy link
Author

MSoeb commented Dec 18, 2023

Re-Tested: The problem didn't occur anymore. It is solved.
@Elblinator Your question is still relevant, but it isn't important for this bug.

-> Issue closed

@MSoeb MSoeb closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high needs investigation The cause for a bug is not clear enough, so it has to be investigated for some time
Projects
None yet
Development

No branches or pull requests

4 participants