Add max per option validator and onkeyon for votes input fields #4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The on change is still needed, for mouse updates. The on key up checks without focus lose.
bastianjoel
requested changes
Dec 19, 2024
| @@ -1,11 +1,11 @@ | |||
| import { AbstractControl, ValidatorFn } from '@angular/forms'; | |||
|
|
|||
| export function isNumberRange(minCtrlName: string, maxCtrlName: string): ValidatorFn { | |||
| export function isNumberRange(minCtrlName: string, maxCtrlName: string, errorName: string): ValidatorFn { | |||
There was a problem hiding this comment.
Might be a good idea to set a default value for that.
Suggested change
| export function isNumberRange(minCtrlName: string, maxCtrlName: string, errorName: string): ValidatorFn { | |
| export function isNumberRange(minCtrlName: string, maxCtrlName: string, errorName: string = `rangeError`): ValidatorFn { |
There was a problem hiding this comment.
Add a default to the validator and use default where possible.
bastianjoel
approved these changes
Dec 19, 2024
Elblinator
requested changes
Jan 6, 2025
There was a problem hiding this comment.
The min-votes are now in warn-colour if the two other amounts are wrong, they should not be in warn colour
If Yes as voting method was selected and then max per option is bigger max per vote and then another voting method is selected then you cannot save the balloot
|
As min-votes, max-votes and max-votes-per option is one form group it is not easy possible to have the validator on just two of the fields. |
|
Add a fix for the problem with setting to 'N' method. |
Elblinator
approved these changes
Jan 7, 2025
bastianjoel
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4453