Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaption validate.py to relational database design #49

Open
r-peschke opened this issue Mar 11, 2024 · 4 comments
Open

Adaption validate.py to relational database design #49

r-peschke opened this issue Mar 11, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@r-peschke
Copy link
Member

r-peschke commented Mar 11, 2024

Start on branch feature/relational_db
The validation-script should pass the tests with the current models.yml. There are some new attributes like reference, deferred and unique. I'm sorry, but there will be more to check.
There is a make target defined as validate-models.
There is a debugger activated, to work you should copy the following code into youtrlaunch.json (VS-Code, Codium):
{
"name": "Python: attach META 5678",
"type": "debugpy",
"request": "attach",
"connect": {
"host": "localhost",
"port": 5678
},
"justMyCode": false,
"pathMappings": [
{
"localRoot": "${workspaceFolder}/openslides-backend/global/meta",
"remoteRoot": "/app"
},
]
},

@r-peschke r-peschke added this to the 4.x milestone Mar 11, 2024
@luisa-beerboom luisa-beerboom self-assigned this Mar 11, 2024
@luisa-beerboom
Copy link
Member

@r-peschke While I am thankful for the explanation on how to set up my work environment in the meta, the description leaves me guessing on what the adaptation would actually entail.

I will try to discern what needs to be done from the code, but if you find the time, could you please at least give me some pointers on what I will have to pay attention to? That would probably greatly speed up the work.

@jsangmeister
Copy link
Contributor

Also, this needs to be done in #17 or, if wanted, in a common feature branch after #17 is merged

@jsangmeister
Copy link
Contributor

In #61, the model validation was disabled in the feature/relational-db branch. This should be reverted as part of this issue.

@jsangmeister
Copy link
Contributor

In #84, the validation is rudimentary enhanced so that the current models.yml passes. This way, the CI can be re-enabled. The validation for the new fields should be enhanced to check what fields are allowed in which cases and to further validate the content of the fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants