Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-numba version #21

Open
Scolymus opened this issue Mar 13, 2023 · 1 comment
Open

Non-numba version #21

Scolymus opened this issue Mar 13, 2023 · 1 comment
Labels
question Further information is requested

Comments

@Scolymus
Copy link

Hi @lukasalexanderweber ,

thanks for this fantastic project! It was very useful for my current project. However, I'm facing some problems due to numba. It's nothing wrong with your code, but with my project when I want to dockerize it. I don't know why, if I add the library numba @ git+https://github.com/numba/[email protected] to my requirements to be installed, my docker is getting ages to be build (I need to use that version because I need to use numpy 1.24 and that branch is the first to be compatible with numpy 1.24).

May I ask you, if is it possible to have a non-numba version? or simply, if you don't wanna have it here, how can I remove numba? just removing the @nb. above function definitions? what about nb.pranges? is just moving them to np.arange?

@lukasalexanderweber
Copy link
Member

lukasalexanderweber commented Mar 14, 2023

Hey @Scolymus,

thanks for the feedback and great that it helped you!

just removing the @nb. above function definitions? what about nb.pranges? is just moving them to np.arange?

yes exactly, I think this should be fine.

I would need to think about how a non-numba version could work. Would you want to also be able to install it from pip or only a git version?

Note also that the performance will be like 4000x slower than without numba, see here for more details. However, for rather small grids it should also be fine.

@lukasalexanderweber lukasalexanderweber added the question Further information is requested label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants