Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the Collection cruft #25

Open
slifty opened this issue Apr 29, 2021 · 1 comment
Open

Get rid of the Collection cruft #25

slifty opened this issue Apr 29, 2021 · 1 comment

Comments

@slifty
Copy link
Contributor

slifty commented Apr 29, 2021

This is a monolithic issue for now, but there is a ton of logic that we simply (HA!) don't use right now.

We should go through the repository and take that complexity out of the plugin. It will make it easier to maintain and more predictable / friendly to potential users who might be surprised when it looks like something exists even though it isn't actually supported.
slifty added a commit that referenced this issue May 5, 2021
@slifty
Rename extension
aa61e0d 
There are a lot of things that need to be renamed, but this is a first
step which will at least allow us to install SimpleBook as "SimpleBook"
instead of "Collection".

This is important because we have officially begun to diverge from
Collection.

SimpleBook and Collection should NOT be installed on the same mediawiki
instance at this point, since they share some of the same configuration
variable names.

Issue #25
@slifty slifty mentioned this issue May 5, 2021
Merged
@slifty slifty mentioned this issue Jun 8, 2021
Merged
@slifty
Copy link
Contributor Author

slifty commented Jun 8, 2021 •
edited
Loading

In addition to unused logic, there are a lot of references to "Collection" overall -- most files names are prefixed with Collection.

We didn't really touch the PHP portion of the plugin, so not much of that needed to be adjusted to get SimpleBook working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slifty