Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing config.yaml #1

Open
radnonymous opened this issue Feb 17, 2021 · 3 comments
Open

Missing config.yaml #1

radnonymous opened this issue Feb 17, 2021 · 3 comments

Comments

@radnonymous
Copy link
Contributor

@click.option('--config', default="config.yaml", help="config file")

This line references a file I can't find in the repository. Is the file missing, or is this the config file referenced in fcebca1 that you are trying to move away from?

@jvasile
Copy link
Member

jvasile commented Feb 17, 2021

I grepped for config and see it is referenced in convert.py and reconcile.py. Convert.py has it as a commandline option and then doesn't use it. We should probably remove that option since we obviously don't need it.

Reconcile.py does appear to use config.yaml, and we have one on our system (we call it reconcile.yaml, but pass it in via --config in our standard reconcile runner script). Mine is below. You'll see I have a template dir, some accounts, some personal finance stuff, etc.

template_dir: "/usr/local/src/ots-bookkeeping/threadfin/reconcile/templates"

accounts: [
{'name': 'main',
'ledger_file': "/home/james/OTS/finances/main.beancount",
},

{'name': 'chase',
'ledger_file': "/home/james/OTS/finances/statements/all.beancount",
},

{'name': 'james_chase',
'ledger_file': "/home/james/Documents/Finances/statements/all.beancount",
},

{'name': 'aadvantage',
'ledger_file': "/home/james/Sync/family/documents/finance/aadvantage/statements/all.beancount"
},

{'name': 'capitalone',
'ledger_file': "/home/james/Sync/family/documents/finance/capitalone/statements/all.beancount"
}
]


reconcile: [
{ 'chase':['Assets:Checking'],
'main': ['Assets:Checking', 'Assets:Guaranteed-Payments']
},
]

So, yes, perhaps it would be good to move away from the config file, but it looks like I didn't find a better place to specify some things. And there is no config file in the repo because the values are so local. The right answers here are probably to 1) remove the --config option from convert.py and 2) add a sample config.yaml file. Feel free to take a swing at either of those!

radnonymous referenced this issue in radnonymous/ots-bookkeeping Feb 18, 2021
@radnonymous
Copy link
Contributor Author

For 2), the sample config.yaml would need to list accounts from sample beancount files and bank statements, correct? So making this change will also need to add sample files to make the config file work, right? Or is the intent for this config file to be a placeholder that the user will edit to match to their local values?

@jvasile
Copy link
Member

jvasile commented Feb 19, 2021

You're right that samples would be the best way to go. That starts to imply a larger task, which is to make a full set of sample files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants