Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a taxon isn't in the synthetic tree, the reason for that should be provided #310

Closed
jar398 opened this issue Jun 12, 2014 · 3 comments

Comments

@jar398
Copy link
Member

jar398 commented Jun 12, 2014

See discussion here:
https://groups.google.com/forum/#!topic/opentreeoflife-software/raWZ7hSfUpI

and corresponding treemachine issue here:
OpenTreeOfLife/treemachine#98

As a first step, before the treemachine service is in place, there should be generic static text saying that the taxon is not in the synthetic tree, either because it is determined to be paraphyletic, or because it was omitted for taxonomic reasons (e.g. it was incertae sedis).

@jar398
Copy link
Member Author

jar398 commented Jun 18, 2014

Can we as a stopgap just display some static text whenever this happens? Something like the following:

"This taxon was not found in the synthetic tree. Usually this happens for one of the following reasons:

  1. The taxon is incompatible with one of the phylogenetic trees that were input to synthesis, i.e. it does not seem to be monophyletic.
  2. The taxon was excluded because it did not have a designated location in the taxonomy (incertae sedis)."

Not that this is a beautiful explanation - we can improve on it - but I think it goes to branding and reputation to do something in this situation; we have seen PIs on the project who don't remember this even after having it explained to them.

Then after we get the needed service from treemachine or taxomachine (as the case may be), we can provide some useful information, such as what trees conflict with monophyly, or what taxonomic information is missing (i.e. what the incomplete lineage is).

@jimallman
Copy link
Member

Can we as a stopgap just display some static text whenever this happens?

This is working now, including a link to the taxon in our taxonomy browser. OK to close this, or do we still want to offer a fuller explanation on demand?

@jar398
Copy link
Member Author

jar398 commented Feb 22, 2016

Working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants