Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxon info needs to report suppressed from synth correctly #104

Open
mtholder opened this issue Nov 19, 2020 · 3 comments
Open

taxon info needs to report suppressed from synth correctly #104

mtholder opened this issue Nov 19, 2020 · 3 comments

Comments

@mtholder
Copy link
Member

see https://tree.opentreeoflife.org/taxonomy/browse?id=4130355

'is_suppressed': False,
'is_suppressed_from_synth': False,

@bredelings
Copy link
Contributor

bredelings commented Dec 1, 2020

OK, so ott413055 is not present in labelled_ott.tre, but it is present in:

  • cleaned_not_updated_ott.tre
  • cleaned_ott_with_hiddenbarren.tre
  • cleaned_ott.tre

It is not in

  • regraft_cleaned_ott.tre

So, presumably it is pruned because it is incertae sedis, but does not occur in a phylogeny.

@bredelings
Copy link
Contributor

bredelings commented Dec 1, 2020

So the obvious way to handle this would just be to check the synth tree and see if it has the node.

If we have multiple synth trees, we could use the default synth tree.

I suppose we could allow a "synth_id" flag on the taxon_info call... which kind of points out that this isn't really a taxonomy property anymore.

@bredelings
Copy link
Contributor

@mtholder Do you think we may have originally assumed that we could determine from the taxonomy alone whether a tree was suppressed from synth?

In theory people could check to see if taxon X exists using taxon_info, and then check to see if the summary tree node "ottX" exists using node_info.

Fixing this issue seems to be the same as doing that inside the server so people don't have to do two calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants