Skip to content
This repository has been archived by the owner on Sep 22, 2019. It is now read-only.

Fix the child/parent induced subtree problem #225

Closed
jar398 opened this issue Jun 22, 2016 · 6 comments
Closed

Fix the child/parent induced subtree problem #225

jar398 opened this issue Jun 22, 2016 · 6 comments

Comments

@jar398
Copy link
Member

jar398 commented Jun 22, 2016

as noted here:
https://github.com/OpenTreeOfLife/opentree/wiki/Open-Tree-of-Life-APIs#induced_subtree

and here:
OpenTreeOfLife/feedback#104

@josephwb
Copy link
Member

? This is not a problem at all; it is working now.

@jar398
Copy link
Member Author

jar398 commented Jun 22, 2016

Excellent! I was just copying the issue over from the feedback repo. Will close both issues.

@jar398 jar398 closed this as completed Jun 22, 2016
@josephwb
Copy link
Member

Note that v2 would return the tree of valid ids as well as list which ids are bad. The v3 does not return any tree if any of the ids are bad (it just tells you which ones are bad).

@jar398
Copy link
Member Author

jar398 commented Jun 23, 2016

Yes of course I know that, I'm the one who made the change. The problem has been under discussion for a while now, but there hasn't been an issue for it, so I just created one: #226

@josephwb
Copy link
Member

I believe I made the change, but regardless I was just making sure that this was still on the radar.

@jar398
Copy link
Member Author

jar398 commented Jun 23, 2016

We both made the change; you did it in treemachine, I did it in taxomachine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants