Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestra helm-chart sets 2x "kubernetes.io/ingress.class: nginx" #40

Open
erkules opened this issue Mar 26, 2022 · 2 comments
Open

Orchestra helm-chart sets 2x "kubernetes.io/ingress.class: nginx" #40

erkules opened this issue Mar 26, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@erkules
Copy link

erkules commented Mar 26, 2022

In nginx.yaml we've got

 kind: Ingress
metadata:
  annotations:
  .....
     kubernetes.io/ingress.class: nginx
    {{ range $key,$value := .Values.network.ingress_annotations }}
    {{ $key }}: {{ quote $value }}
    {{ end }}

In values.yaml we've got

ingress_annotations: kubernetes.io/ingress.class: nginx

So the label kubernetes.io/ingress.class: nginx is set 2x.

Even working with helm it is not a valid yaml and breaks i.e. in fluxcd.

Workaround:
ingress_annotations: kubernetes.io/ingress.class: null

@erkules
Copy link
Author

erkules commented Mar 26, 2022

I'm not sure if there is a plan to remove one of the labels.
But if so, I would suggest removing it from network.ingress_annotations. So installations using the workaround don't break.

mlbiam added a commit to mlbiam/helm-charts that referenced this issue Mar 27, 2022
@mlbiam mlbiam added the bug Something isn't working label Mar 27, 2022
@mlbiam mlbiam self-assigned this Mar 27, 2022
@mlbiam
Copy link
Contributor

mlbiam commented Mar 27, 2022

i removed the labels from the default values.yaml and from the docs. Bump to the latest version and you should be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants