Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing choropleth percentage calculations #350

Closed
wants to merge 1 commit into from
Closed

fixing choropleth percentage calculations #350

wants to merge 1 commit into from

Conversation

emre2038
Copy link
Contributor

@emre2038 emre2038 commented May 23, 2021

Description

Checking & fixing choropleth percentage calculations

Related Issue

#349

How to test it locally

Screenshots

Changelog

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally
  • 👩‍🎨 does the design matches the Demo

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@emre2038 emre2038 self-assigned this May 23, 2021
@emre2038 emre2038 added this to the 0.14 milestone May 23, 2021
@emre2038 emre2038 linked an issue May 23, 2021 that may be closed by this pull request
@netlify
Copy link

netlify bot commented May 23, 2021

Deploy Preview for wazimap-staging ready!

Built with commit 19075ce

https://deploy-preview-350--wazimap-staging.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discrepancies in choropleth between staging and master
2 participants