From 8cc724d6cf3d4a0fe20fc2fa3683c9dc711b3296 Mon Sep 17 00:00:00 2001
From: Carlos Santos <4a.santos@gmail.com>
Date: Thu, 11 Jul 2024 23:14:32 +0200
Subject: [PATCH] backend: Improved logs

---
 openvidu-call-back/src/controllers/webhook.controller.ts | 3 +--
 openvidu-call-back/src/models/error.model.ts             | 4 ++--
 openvidu-call-back/src/services/room.service.ts          | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/openvidu-call-back/src/controllers/webhook.controller.ts b/openvidu-call-back/src/controllers/webhook.controller.ts
index 65d6b1b3..fdc2b0d7 100644
--- a/openvidu-call-back/src/controllers/webhook.controller.ts
+++ b/openvidu-call-back/src/controllers/webhook.controller.ts
@@ -24,8 +24,7 @@ export const webhookHandler = async (req: Request, res: Response) => {
 			isRoomCreatedByMe = roomOrRoomName ? await roomService.isRoomCreatedByMe(roomOrRoomName) : false;
 		}
 
-		// Skip webhook events that are not related to OpenVidu Call only if there is a room or room name
-		// and the room was not created by me
+		// Skip webhook events that are not related to OpenVidu Call
 		if (roomOrRoomName && !isRoomCreatedByMe) {
 			logger.verbose(`Skipping webhook, event is not related to OpenVidu Call: ${eventType}`);
 			return res.status(200).send();
diff --git a/openvidu-call-back/src/models/error.model.ts b/openvidu-call-back/src/models/error.model.ts
index 94f9b1b5..0b4b63f7 100644
--- a/openvidu-call-back/src/models/error.model.ts
+++ b/openvidu-call-back/src/models/error.model.ts
@@ -57,7 +57,7 @@ export const errorRecordingAlreadyStarted = (roomName: string): OpenViduCallErro
 // Broadcasting errors
 
 export const errorSessionWithoutParticipants = (roomName: string): OpenViduCallError => {
-	return new OpenViduCallError('Broadcasting Error', `The room '${roomName}' do not have participants`, 406);
+	return new OpenViduCallError('Broadcasting Error', `The room '${roomName}' does not have participants`, 406);
 };
 
 export const errorBroadcastingAlreadyStarted = (roomName: string): OpenViduCallError => {
@@ -70,7 +70,7 @@ export const errorBroadcastingNotStarted = (roomName: string): OpenViduCallError
 
 // Room errors
 export const errorRoomNotFound = (roomName: string): OpenViduCallError => {
-	return new OpenViduCallError('Room Error', `The room '${roomName}' do not exist`, 404);
+	return new OpenViduCallError('Room Error', `The room '${roomName}' does not exist`, 404);
 };
 
 export const errorParticipantAlreadyExists = (participantName: string, roomName: string): OpenViduCallError => {
diff --git a/openvidu-call-back/src/services/room.service.ts b/openvidu-call-back/src/services/room.service.ts
index ad942d73..4d894171 100644
--- a/openvidu-call-back/src/services/room.service.ts
+++ b/openvidu-call-back/src/services/room.service.ts
@@ -86,7 +86,7 @@ export class RoomService {
 			const metadata = room.metadata ? JSON.parse(room.metadata) : null;
 			return metadata?.createdBy === CALL_NAME_ID;
 		} catch (error) {
-			console.warn('Error getting Room while parsing webhook checking if isRoomCreatedByMe:', error);
+			console.warn('Error getting Room while checking webhook. Room may no longer exist. Ignoring');
 			return false;
 		}
 	}