feat/number_spans #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
port/lingua-nostra/pull/25
branch
from
e18ddcb
to
be3a1bb
Compare
feat/normalize_decimals port lingua_nostra/pull/20 - support decimal markers rebase of MycroftAI#69 Co-authored-by: jarbasal <[email protected]>
JarbasAl
force-pushed
the
port/lingua-nostra/pull/25
branch
from
be3a1bb
to
eb257da
Compare
emphasize
reviewed
Jan 4, 2023
| @@ -143,20 +144,28 @@ def repl(match): | |||
| return (duration, text) | |||
|
|
|||
|
|
|||
| def extract_number_de(text, short_scale=True, ordinals=False): | |||
| def extract_number_de(text, short_scale=True, ordinals=False, decimal='.'): | |||
There was a problem hiding this comment.
the default of decimal should be a comma, as this is the common form
There was a problem hiding this comment.
this is part of #43 which was dragged in this PR accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.