Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebased UK Parse PR #56

Merged
merged 16 commits into from
Jun 18, 2024
Merged

Rebased UK Parse PR #56

merged 16 commits into from
Jun 18, 2024

Conversation

NeonDaniel
Copy link
Member

Rebased #51 on dev with #50 merged

@NeonDaniel NeonDaniel force-pushed the parse_uk branch 2 times, most recently from 19d1549 to 55519f5 Compare April 14, 2023 16:32
@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@4d5ce0d). Learn more about missing BASE report.

❗ Current head 5cbbb53 differs from pull request most recent head b6b6108

Please upload reports for the commit b6b6108 to get more accurate results.

Files Patch % Lines
lingua_franca/lang/format_uk.py 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##             dev     #56   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      69           
  Lines          ?   18396           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?   18396           
  Partials       ?       0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel mentioned this pull request Apr 14, 2023
Closed
@NeonDaniel NeonDaniel marked this pull request as ready for review April 20, 2023 17:44
NeonDaniel
NeonDaniel commented Apr 20, 2023
View reviewed changes
lingua_franca/format.py Outdated Show resolved Hide resolved
lingua_franca/format.py Outdated Show resolved Hide resolved
lingua_franca/lang/parse_common.py Outdated Show resolved Hide resolved
test/unittests/test_format_uk.py Outdated Show resolved Hide resolved
test/unittests/test_format_uk.py Outdated Show resolved Hide resolved
test/unittests/test_format_uk.py Outdated Show resolved Hide resolved
test/unittests/test_format_uk.py Outdated Show resolved Hide resolved
@NeonDaniel NeonDaniel requested a review from a team April 26, 2023 18:03
@NeonDaniel NeonDaniel mentioned this pull request Jul 12, 2023
Merged
@NeonDaniel NeonDaniel mentioned this pull request Apr 4, 2024
Closed
@NeonDaniel NeonDaniel mentioned this pull request Jun 18, 2024
Merged
@NeonDaniel
Copy link
Member Author

@NeonDmitry @NeonBohdan can one of you review this? I'm not sure we have any other qualified Ukrainian speakers.

@JarbasAl JarbasAl merged commit 7d67ffd into dev Jun 18, 2024
9 checks passed
@JarbasAl JarbasAl deleted the parse_uk branch June 18, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeonDmitry NeonDmitry NeonDmitry approved these changes

@ChanceNCounter ChanceNCounter Awaiting requested review from ChanceNCounter

@emphasize emphasize Awaiting requested review from emphasize

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NeonDaniel @ChanceNCounter @emphasize @NeonDmitry @JarbasAl @NeonMariia