Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve context in queries #21

Open
NeonDaniel opened this issue Sep 13, 2022 · 0 comments
Open

Preserve context in queries #21

NeonDaniel opened this issue Sep 13, 2022 · 0 comments
Labels
wontfix This will not be worked on

Comments

@NeonDaniel
Copy link
Member

Incoming queries should forward Message objects instead of creating new ones so search results can be associated to the originating request. This could probably just use dig_for_message or pass a Message object to the search method and then associate add a message property to OCPQuery to keep the same message associated with the request and results

ovos-ocp-audio-plugin/ovos_plugin_common_play/ocp/search.py

Line 321 in 05a9bf2

def search(self, phrase, media_type=MediaType.GENERIC):

@JarbasAl JarbasAl mentioned this issue Feb 25, 2024
Open
@JarbasAl JarbasAl added the wontfix This will not be worked on label May 10, 2024
@JarbasAl JarbasAl removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JarbasAl @NeonDaniel