Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nrtest comparison tolerance parameterization #122

Closed
michaeltryby opened this issue Oct 26, 2017 · 0 comments
Closed

Update nrtest comparison tolerance parameterization #122

michaeltryby opened this issue Oct 26, 2017 · 0 comments

Comments

@michaeltryby
Copy link

michaeltryby commented Oct 26, 2017

Comparison tolerances are an important, but often overlooked, aspect of numerical regression testing. There is a need to associate comparison tolerance parameters with specific comparison routines and tests to increase flexibility when performing comparisons.

The python package nrtest currently only allows one type of parameterization and it can only be modified globally. Therefore, specific changes to nrtest are needed to:

  1. Allow different comparison tolerance parameters for different comparison routines
  2. Associate comparison tolerance parameter values with specific tests
  3. Maintain the ability to modify comparison tolerance parameters globally

These modifications would enhance the value of nrtest for the OWA/EPANET and SWMM projects. See nrtest Issue #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant