Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify discussion of CloudFront origin #13

Open
smalers opened this issue Sep 29, 2022 · 0 comments
Open

Clarify discussion of CloudFront origin #13

smalers opened this issue Sep 29, 2022 · 0 comments
Labels
low Priority: planned for future task Something that needs to get done

Comments

@smalers
Copy link
Contributor

smalers commented Sep 29, 2022

The following text was in the documentation but is confusing and has been removed:

Note that this example uses the origin content of the S3 bucket, not the served static website.
This is done on purpose to illustrate how to resolve the issue with `index.html` not being the default file in a folder when using CloudFront.

I think we needed to use the S3 bucket for the CloudFront origin and not the URL to the S3 site (probably the internal URL?). Maybe try an experiment when there is time. I think the bigger issue is that for single page applications we needed to deal with base href. Figure out if this text is relevant or not.

@smalers smalers added low Priority: planned for future task Something that needs to get done labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low Priority: planned for future task Something that needs to get done
Projects
None yet
Development

No branches or pull requests

1 participant