EIP165 in EIP721 #71
andrew-fleming
started this conversation in
Design
Replies: 1 comment 1 reply
-
One option that I think you didn't mention is that we could just copy the inteface identifier constant verbatim, instead of recomputing it in Cairo. If we're going with implementing ERCs to the letter (see the discussion about camel case), I think this is the only option that is coherent with that approach. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
What is the best path forward regarding the incorporation of EIP165 with EIP721 (and subsequently, in general)? Being that StarkNet handles selectors by using the function name (versus the signature with EVM), how should we best approach implementing EIP165? A big thanks to @dewi-tim for bringing this up and offering the following options to consider.
Should we:
My initial response leaned towards thinking that using the builtins on felts would be cheaper; however, regular arithmetic to compute the interfaceId may be less costly (if we don't know for certain, could be a good little research project). Or, of course, should we aim towards EVM compatibility? What other implications should be considered?
An important aspect to contemplate as well is @martriay 's comment in ERC20 function naming—namely, the meta of should these standards in Cairo be interoperable with EVM or should they move away from EVM.
What do you guys think?
Beta Was this translation helpful? Give feedback.
All reactions