Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define from and to as indexed keys in ERC20 Transfer event #697

Closed
yoga-braavos opened this issue Aug 13, 2023 · 1 comment
Closed

Define from and to as indexed keys in ERC20 Transfer event #697

yoga-braavos opened this issue Aug 13, 2023 · 1 comment
Assignees
@andrew-fleming

Comments

@yoga-braavos
Copy link

yoga-braavos commented Aug 13, 2023 •
edited
Loading

cairo-contracts/src/token/erc20/erc20.cairo

Line 30 in 457b98b

struct Transfer {

Per Ethereum's ERC20 implementation both to and from are indexed:
https://ethereum.org/en/developers/docs/standards/tokens/erc-20/#events

Now that Cairo supports the #[key] attribute, it should be possible to easily align to Ethereum's spec
@martriay martriay added this to the next milestone Aug 15, 2023
@martriay martriay moved this to 📋 Backlog in Contracts for Cairo Aug 15, 2023
@martriay martriay modified the milestones: next, current Aug 22, 2023
@martriay martriay moved this from 📋 Backlog to 🏗 In progress in Contracts for Cairo Sep 18, 2023
@andrew-fleming andrew-fleming mentioned this issue Sep 22, 2023
Merged
@andrew-fleming andrew-fleming self-assigned this Sep 28, 2023
@andrew-fleming andrew-fleming moved this from 🏗 In progress to 👀 In review in Contracts for Cairo Sep 28, 2023
@martriay
Copy link
Contributor

Fixed by #746.

@martriay martriay moved this from 👀 In review to ✅ Resolved in Contracts for Cairo Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-fleming andrew-fleming

Labels
None yet
Projects
Contracts for Cairo
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martriay @andrew-fleming @yoga-braavos