Skip to content

Use onlyGovernance for Governor with UUPS #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericglau opened this issue Jul 1, 2022 · 2 comments · Fixed by #544
Closed

Use onlyGovernance for Governor with UUPS #144

ericglau opened this issue Jul 1, 2022 · 2 comments · Fixed by #544
Labels
good first issue Good for newcomers

Comments

@ericglau
Copy link
Member

ericglau commented Jul 1, 2022

Governor with UUPS currently uses onlyOwner for the _authorizeUpgrade function. Instead, change this to onlyGovernance.
@ericglau ericglau added the good first issue Good for newcomers label Jan 9, 2023
@elisafalk elisafalk mentioned this issue Apr 28, 2025
Closed
@elisafalk
Copy link
Contributor

@ericglau Hope you are having a good day! I have send the pull request for this issue #532 . Please review it and merge if it looks good.

@elisafalk elisafalk mentioned this issue May 12, 2025
Merged
@elisafalk
Copy link
Contributor

@ericglau @CoveMB I have send the PR. Please merge this PR if it looks correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@ericglau @elisafalk