Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage to 100% #1147

Closed
nventuro opened this issue Aug 2, 2018 · 1 comment
Closed

Increase coverage to 100% #1147

nventuro opened this issue Aug 2, 2018 · 1 comment
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Milestone
v2.0

Comments

@nventuro
Copy link
Contributor

nventuro commented Aug 2, 2018

Coverage has remained at 95% for quite a bit, though I'm not sure if this is really a fault of our test suite, or an integration issue with solidity-coverage (see #1137). We should look into this, figure out what's missing/wrong, and bump the coverage figure.
@nventuro nventuro added good first issue Low hanging fruit for new contributors to get involved! kind:improvement tests Test suite and helpers. labels Aug 2, 2018
@nventuro nventuro added this to the v2.0 milestone Aug 2, 2018
@nventuro nventuro mentioned this issue Aug 2, 2018
Closed
@nventuro nventuro mentioned this issue Aug 12, 2018
Merged
@nventuro nventuro mentioned this issue Aug 24, 2018
Merged
This was referenced Aug 29, 2018
Merged
Merged
@frangio
Copy link
Contributor

frangio commented Aug 29, 2018

This has progressed quite a lot. 100% is not doable because of sc-forks/solidity-coverage#269.

@frangio frangio closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
2 participants
@frangio @nventuro