Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 [Feature Request]: DealWithFees #220

Open
3 tasks done
4meta5 opened this issue Jun 7, 2024 · 0 comments
Open
3 tasks done

🎁 [Feature Request]: DealWithFees #220

4meta5 opened this issue Jun 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@4meta5
Copy link
Contributor

4meta5 commented Jun 7, 2024

templates

  • Generic Runtime Template
  • Evm Template

What is the feature you would like to see?

Both pallet_transaction_payment Configs lack DealWithFees implementations so all fees are burned by default.

We should consider following norms around Treasury usage to instead set a DealWithFees implementation that transfers 20% of fees to the treasury account and burns the rest. This DealWithFees impl would also be used in the xcm_executor::Trader config (see #215 for the part where it is currently set to ()).

This is an important config that may motivate documentation to show users how to set it themselves according to their project's custom tokenomics.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@4meta5 4meta5 added the enhancement New feature or request label Jun 7, 2024
@4meta5 4meta5 added this to the Future Steps milestone Jun 7, 2024
@4meta5 4meta5 self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🗒 Backlog
Development

No branches or pull requests

1 participant