From 9916a7c2bc2df5926415626288559ab81ece631f Mon Sep 17 00:00:00 2001 From: Jamey Huffnagle Date: Tue, 10 Sep 2024 11:53:16 -0400 Subject: [PATCH] fix(app): fix gray run status when pressing "return to dash" on `RunSummary` (#16223) Closes RQA-3159 Fixes the run status changing to gray when clicking "return to dashboard" on the ODD RunSummary page. The run status graying on button click has always been in the code, but because we used to navigate immediately after clicking "return to dashboard", this wasn't a user-visible problem. --- app/src/pages/RunSummary/index.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/pages/RunSummary/index.tsx b/app/src/pages/RunSummary/index.tsx index 7669ebc75cc..ec555f40078 100644 --- a/app/src/pages/RunSummary/index.tsx +++ b/app/src/pages/RunSummary/index.tsx @@ -147,7 +147,7 @@ export function RunSummary(): JSX.Element { const trackEvent = useTrackEvent() const { trackEventWithRobotSerial } = useTrackEventWithRobotSerial() - const { closeCurrentRun, isClosingCurrentRun } = useCloseCurrentRun() + const { closeCurrentRun } = useCloseCurrentRun() // Close the current run only if it's active and then execute the onSuccess callback. Prefer this wrapper over // closeCurrentRun directly, since the callback is swallowed if currentRun is null. const closeCurrentRunIfValid = (onSuccess?: () => void): void => { @@ -386,7 +386,6 @@ export function RunSummary(): JSX.Element { flexDirection={DIRECTION_COLUMN} position={POSITION_RELATIVE} overflow={OVERFLOW_HIDDEN} - disabled={isClosingCurrentRun} onClick={handleClickSplash} > {showSplash ? (