Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding of transmitted isotp messages simplifies usage #3

Open
Frankyboy100880 opened this issue Aug 4, 2020 · 4 comments
Open

Padding of transmitted isotp messages simplifies usage #3

Frankyboy100880 opened this issue Aug 4, 2020 · 4 comments

Comments

@Frankyboy100880
Copy link

Many thanks for the great library, which saves us a lot of time.

During a proof of concept we stumbled upon a problem, which could be only resolved by changing the Curf.py a bit.

Can you please change the following line in Curf.py on line 213, so that messages not fitting an 8 Byte Can-Frame are automatically filled up with padding bytes:

self.isotp_stack = isotp.CanStack(
     bus=self.bus, 
     address=self.isotp_addr,  
     error_handler=self.curf_error_handler, 
     params = {"tx_padding":0x55}) 
@RomainNaour
Copy link
Member

@Frankyboy100880

Can you send a Pull Request containing your patch ?

Best regards,
Romain

@Frankyboy100880
Copy link
Author

Frankyboy100880 commented Aug 5, 2020

I'm unable to push a new branch to this repo. Am I allowed to do so? Can I create a branch here with the Web frontend of GitHub?

I tried it directly, but there are problems with my credentials:

$ git push --set-upstream origin Hotfix/AddPadding                                                                         
remote: Permission to Openwide-Ingenierie/robotframework-can-uds-library.git denied to Frankyboy100880.
fatal: unable to access 'https://github.com/Openwide-Ingenierie/robotframework-can-uds-library.git/': The requested URL returned error: 403

@RomainNaour
Copy link
Member

RomainNaour commented Aug 5, 2020

@Frankyboy100880

The github process to send a Pull Request is:

  • fork the upstream repository to your github account
  • push your branch you want to contribute
  • create a Pull Request from you account to the upstream repo.

https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

@Frankyboy100880
Copy link
Author

Thanks for the help. I created a pull request for my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants