consent handling: Refactor and various fixes #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapo
force-pushed
the
refactor-consent
branch
3 times, most recently
from
63e2da0 to
7a8be2f
Compare
zapo
force-pushed
the
refactor-consent
branch
from
7a8be2f to
2721deb
Compare
Nikola-Milekic
approved these changes
Feb 19, 2025
xcapaldi
reviewed
Feb 19, 2025
zapo
force-pushed
the
refactor-consent
branch
2 times, most recently
from
c7f89cb to
f9e51d3
Compare
zapo
force-pushed
the
refactor-consent
branch
from
f9e51d3 to
942f5ce
Compare
xcapaldi
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop passing detected regulation to DCN, let it infer it as it may use more accurate signals (geoip)
Rename "tcf" query param to "gdpr_consent" (aligns with TCFv2 examples of full tc passing https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/blob/master/TCFv2/IAB%20Tech%20Lab%20-%20Consent%20string%20and%20vendor%20list%20formats%20v2.md#full-tc-string-passing)
Pass along gdprApplies from CMP as "gdpr" number
Use tcf's
gdprAppliesand gpp'sapplicableSectionswhen defined by CMP to infer applicable regulation / handle consent.Eg:
gdprApplies: trueforcesreg: gdprregardless what was initially detected.Add missing timezones for GDPR detection