-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mongodb as a default database for application #92
Conversation
Hello 👋, thank you for opening new PR to OqixTS 💗 Please, wait till somebody will review your PR. |
8698569
to
3150425
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
acda348
to
774aa8c
Compare
Ok I think it is ready for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for the possibility of re-verifying with the requirement of deleting old verification assigned to the thesis. Request to add the date of verification to the user object.
Reverify option is little bit complicated since we need to define when is user able to reverify - For example there is big difference when the user is kicked from the server and when he leaves on its own. Is only situation when he can reverify when he leaves on its own or do we want to have option to "lift the ban". If the second option is true, then I would suggest leaving it for now and making it separate feature. As for the the date of verification. Do you have something in mind how we would use it? Because first of all I would like to keep amount of data we store to minimum (mainly to protect students) and we also have currently quite a few people who are already verfied therefore simplest thing would be to add same date to each one, and I do not find that too useful 🤔 . |
Regarding the second request, I see it useful for security reasons when auditing suspicious behaviour... for example cases when there would be some leak from the server, we can filter out users verified in that period and check their behaviour about the leak. |
Signed-off-by: Michal Drla <[email protected]>
Converted back to draft since I am finishing the work on kicked and banned reverification and needs little bit more work. |
4164fab
to
cccab70
Compare
Signed-off-by: Michal Drla <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Now we have also states removed and banned. These states work this way: |
/lgtm |
Related issues
Resolves #60
Type of pull request
Describe your PR in detail
This PR adds mongodb database as a default database for the application. It utilizes mongodb atlas shared tier since it is fairly generous, later with the application would grow too large we might want to reconsider alternatives...
It uses Prisma as ORM
Also adds new states for status -> removed and banned, where removed users can reverify but banned users can't.