Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#283] Add code example to show how to use token in tokens pages of demo app #297

Merged
merged 26 commits into from
Nov 29, 2024

Conversation

Tayebsed93
Copy link
Collaborator

@Tayebsed93 Tayebsed93 commented Nov 19, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#283

Description

Add in view sections with code sample to explain to user show they can use the tokens

Motivation & Context

Make users able to learn how they can use the tokens, exactly like with ODS demo app

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@Tayebsed93 Tayebsed93 linked an issue Nov 19, 2024 that may be closed by this pull request
1 task
@Tayebsed93 Tayebsed93 force-pushed the 283-demoapp-add-code-example-to-show-how-to-use-token branch 2 times, most recently from 7a22999 to 880aaf5 Compare November 21, 2024 10:23
@Tayebsed93 Tayebsed93 marked this pull request as ready for review November 21, 2024 10:23
@Tayebsed93 Tayebsed93 changed the title Token code example Add code example to show how to use token Nov 21, 2024
@pylapp pylapp self-assigned this Nov 21, 2024
pylapp

This comment was marked as resolved.

@Tayebsed93 Tayebsed93 force-pushed the 283-demoapp-add-code-example-to-show-how-to-use-token branch from b79df14 to 19b5e5e Compare November 21, 2024 14:59
pylapp

This comment was marked as outdated.

@pylapp pylapp changed the title Add code example to show how to use token [#283] Add code example to show how to use token in tokens page of demo app Nov 21, 2024
@Tayebsed93 Tayebsed93 force-pushed the 283-demoapp-add-code-example-to-show-how-to-use-token branch from bdf7fc7 to b048d5d Compare November 25, 2024 12:17
@Tayebsed93 Tayebsed93 requested a review from pylapp November 25, 2024 13:16
pylapp

This comment was marked as outdated.

@Tayebsed93 Tayebsed93 requested a review from pylapp November 25, 2024 14:00
pylapp

This comment was marked as outdated.

@pylapp pylapp added the ⌛ waiting for validations The issue associated to this pull request is being reviewed by PO / a11y tea design team label Nov 25, 2024
@ludovic35 ludovic35 removed the ⌛ waiting for validations The issue associated to this pull request is being reviewed by PO / a11y tea design team label Nov 27, 2024
@ludovic35 ludovic35 force-pushed the 283-demoapp-add-code-example-to-show-how-to-use-token branch from 4b20e7c to a2177e5 Compare November 27, 2024 16:15
@ludovic35
Copy link
Member

@pylapp Need to review last commit

@pylapp pylapp self-requested a review November 28, 2024 12:05
@pylapp pylapp changed the title [#283] Add code example to show how to use token in tokens page of demo app [#283] Add code example to show how to use token in tokens pages of demo app Nov 28, 2024
@pylapp pylapp force-pushed the 283-demoapp-add-code-example-to-show-how-to-use-token branch from a2177e5 to 763ce9d Compare November 29, 2024 09:34
pylapp
pylapp previously approved these changes Nov 29, 2024
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after some fixes / refactoring from my side)

@pylapp pylapp merged commit dcd69ea into develop Nov 29, 2024
5 of 8 checks passed
@pylapp pylapp deleted the 283-demoapp-add-code-example-to-show-how-to-use-token branch November 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DemoApp] Add code example to show how to use token
3 participants