-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#283] Add code example to show how to use token in tokens pages of demo app #297
Merged
pylapp
merged 26 commits into
develop
from
283-demoapp-add-code-example-to-show-how-to-use-token
Nov 29, 2024
Merged
[#283] Add code example to show how to use token in tokens pages of demo app #297
pylapp
merged 26 commits into
develop
from
283-demoapp-add-code-example-to-show-how-to-use-token
Nov 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
7a22999
to
880aaf5
Compare
b79df14
to
19b5e5e
Compare
bdf7fc7
to
b048d5d
Compare
4b20e7c
to
a2177e5
Compare
@pylapp Need to review last commit |
a2177e5
to
763ce9d
Compare
pylapp
previously approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (after some fixes / refactoring from my side)
… color Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
#283
Description
Add in view sections with code sample to explain to user show they can use the tokens
Motivation & Context
Make users able to learn how they can use the tokens, exactly like with ODS demo app
Types of change
Previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)