Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tokens #319

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Conversation

boosted-bot
Copy link
Collaborator

This PR is generated automatically, it updates the tokens based on Figma Variables.

@pylapp
Copy link
Member

pylapp commented Nov 28, 2024

@julien-deramond FYI, we have a linter warning about how numbers should be written (more details here).
For example, the "1336" should be written "1_336" with an underscore.
If the tokenator cannot manage this case, add the following SwiftLint disable command in the top of the file and the enable in the bottom (beside for example missing_docs):

// swiftlint:disable number_separator
// swiftlint:enable number_separator

Unit tests have been updated in our side as new raw tokens came and some have been removed.

BTW, this PR will be merged with modifications I brought :)

@pylapp pylapp force-pushed the tokenator-update-tokens-20241128161629 branch from d8b1756 to d906255 Compare November 28, 2024 16:07
@pylapp pylapp merged commit 3780168 into develop Nov 28, 2024
6 of 8 checks passed
@pylapp pylapp deleted the tokenator-update-tokens-20241128161629 branch November 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants