Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#403] Add missing assets for Button screen #404

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

ludovic35
Copy link
Member

@ludovic35 ludovic35 commented Jan 23, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • (NA) Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

@ludovic35 ludovic35 linked an issue Jan 23, 2025 that may be closed by this pull request
1 task
@ludovic35 ludovic35 changed the title [403] Add missing assets [403] Add missing assets for Button screen Jan 23, 2025
@ludovic35 ludovic35 marked this pull request as ready for review January 23, 2025 10:28
@ludovic35 ludovic35 requested a review from pylapp as a code owner January 23, 2025 10:28
pylapp
pylapp previously approved these changes Jan 23, 2025
Copy link
Member

@pylapp pylapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon pour moi en considérant le fait que certaines tests UI mécaniquement ne passe plus ; ils devront avoir leurs images de références refaites.

@pylapp pylapp self-assigned this Jan 23, 2025
@pylapp pylapp merged commit e31d3b8 into develop Jan 23, 2025
7 of 8 checks passed
@pylapp pylapp deleted the 403-bug-illustration-missing-on-button-card branch January 23, 2025 11:14
@pylapp pylapp changed the title [403] Add missing assets for Button screen [#403] Add missing assets for Button screen Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Illustration missing on Button card
2 participants