Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library dependency has internet activity #4

Open
DaniilSokolyuk opened this issue Jun 25, 2020 · 3 comments
Open

Library dependency has internet activity #4

DaniilSokolyuk opened this issue Jun 25, 2020 · 3 comments

Comments

@DaniilSokolyuk
Copy link

domainname-parser dependency has internet acitivy
https://github.com/OrbintSoft/domainname-parser/blob/ebaa1bf0430b5412a8c51a2bcab0262e7da16df4/DomainParser.Library/TLDRulesCache.cs#L294
library must have a fallback, or settings to turn off it.
In private network this cause thread pool exhaustion

image

@DaniilSokolyuk
Copy link
Author

DaniilSokolyuk commented Jun 25, 2020

All threads wait at that line
image

@OrbintSoft
Copy link
Owner

I don't think the real problem is the internet activity, that library simply downloads an updated version of https://publicsuffix.org/list/public_suffix_list.dat.
You can download the file by yourself, and the parser will work fine without internet.

In next version a will add the file as static resource, so it will be available without internet.

Anyway the real issue here is that library causes a thread pool exhaustion.

I am planning to remove that library in any case in a future version because has many issues.

This is the library: https://github.com/danesparza/domainname-parser.

Yauaa uses forked version with .NetStandard compatibility and Strong Signature, but you can refer to that repository.

A

@DaniilSokolyuk
Copy link
Author

Ok, thanks.
Thanks for your work, this library really good parse user agents :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants