Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons To Fix #4

Open
shazada opened this issue Aug 26, 2014 · 8 comments
Open

Addons To Fix #4

shazada opened this issue Aug 26, 2014 · 8 comments

Comments

@shazada
Copy link

shazada commented Aug 26, 2014

This will be a list of Addons we should fix to add to our available list.

These could be the https://wiki.alfresco.com/wiki/Projects_and_Teams_Global_Virtual_Hack-a-thon_2014 projects or maybe Addons which are only working for an older version and need an upgrade.

@apillai
Copy link

apillai commented Sep 25, 2014

We've updated the FiveStar Ratings add-on for 4.2.f and also integrated with Mahout for Content Recommendations based on ratings feedback. Open sourced at https://github.com/zaizi/alfresco-recommendations. Whats the next steps for including this in Honeycomb?

@aviriel
Copy link
Member

aviriel commented Sep 25, 2014

Aingaran,
You can add the link and description to https://github.com/OrderOfTheBee/addons/wiki/Candidates-of-our-favorite-free-open-source-add-ons. I believe that ADDONS committee looks at these addons one by one and will start adding them to the website ASAP. Now everyone is too busy preparing to Summit in London.

@apillai
Copy link

apillai commented Sep 25, 2014

@aviriel Thanks. I know there were discussions on what minimum criteria add-ons need to meet to be considered for inclusion in Honeycomb. Was the final set of criteria documented any where?

@AFaust
Copy link
Contributor

AFaust commented Sep 25, 2014

@apillai I wanted to summarize the discussion and prepare the criteria documentation in the wiki, but as aviriel pointed out, time has been in short supply lately (Summit preparation + new project / sales travel). At the moment, the rules are only in the issue discussion and not final. Once the summary of the discussion is complete, this should be put to a vote inside the committee and (with any modifications that may arise) used as the set of rules for the first addons.

@marsbard
Copy link

@apillai I have added this extension to my vagrant/puppet build of alfresco here: https://github.com/marsbard/ootb-allinone-mysql

(I'm hoping/planning that this will become the way that we both test our honeycomb additions, as well as being a method for admins to provision the honeycomb edition of alfresco)

It builds and installs OK. I can see that there is a dashlet called "Recommended documments (sic)" but I cannot see how to recommend a document so it shows up in the dashlet. In terms of this committee and how we determine acceptance criteria I suggest that we make a requirement for enough user documentation to be able to use the features of the addon.

Furthermore, with this vagrant/puppet build I want to create a test harness using http://robotframework.org/ and selenium and require that each addon has a set of acceptance tests which have to pass before it is accepted into honeycomb.

To this end I'm wondering if you have any selenium based acceptance tests within your organisation which relate to this addon. At the moment I would want to see:

  • Create a site for the test
  • Add recommendation dashlet to the site and verify its presence
  • Add a document to the site and set a recommendation on it
  • Verify the recommendation in the dashlet

In the long run I would hope to see the sponsor of an addon (whether that be the author or someone else who feels strongly that an addon be included) creating the puppet configuration to include the addon as well as creating the basic acceptance tests using selenium, and possibly also bringing the documentation up to scratch. The idea is that anyone can download the vagrant build, tweak it until it works with their addon, and then make a pull request to get it included. To that end, it is useful to know which files were touched to add your addon, I've used them as an example in this HOWTO: https://github.com/marsbard/ootb-allinone-mysql/blob/master/ADDON_HOWTO.md

@marsbard
Copy link

So I've just realised that my comments above are relating to getting an addon accepted for inclusion in Honeycomb Distribution of Alfresco and hence belong in the DISTRO committee.

The criteria for accepting an addon for inclusion in our curated list of addons will necessarily be less onerous I think.

@shazada
Copy link
Author

shazada commented Sep 29, 2014

@marsbard Creating tests is fine, we do that with JMeter for a couple of customers, but I mean writings tests for all Addons is a bit too much to ask from the committee :). Sure if anyone wants to do it, then that's oke, but it shouldn't be part of the acceptance requirements.

@shazada
Copy link
Author

shazada commented Sep 29, 2014

@marsbard Oeps, I saw your comment: "The criteria for accepting an addon for inclusion in our curated list of addons will necessarily be less onerous I think." So yes, we won't add it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants