Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some questions #140

Open
wsxiya opened this issue Jan 7, 2025 · 1 comment
Open

Some questions #140

wsxiya opened this issue Jan 7, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@wsxiya
Copy link

wsxiya commented Jan 7, 2025

Thank you very much for updating this mod to NeoForge 1.21.1. However, I noticed that in 1.21.1 NeoForge, you cannot see the steam particles when lava comes into contact with water while underwater, whereas in 1.12.2, it displays fully. Additionally, I found that the steam particles in 1.12.1 are not smooth and have a stuttering feel. By the way, I would like to ask if you will add the sound of crafting items to 1.21.1, as I believe most people really enjoy the sound of item crafting. If I have disturbed you, please feel free to close this issue.

freecompress-1736243638781.mp4
@OreCruncher
Copy link
Owner

OreCruncher commented Jan 7, 2025

The particle rendering behavior is due to clipping. The 1.12.x version used custom rendering, as well as Minecraft's rendering system was entirely different than what exists today. I am in the process of changing how my particles are rendered - maybe I can do something there.

As for crafting sounds it most likely will not come back. The reason it was removed because it relied on a crafting event that was server side. Dynamic Surroundings is now a 100% client-side mod without any server dependency. Mojang made a lot of changes to the internal workings of Minecraft, and I haven't revisited the topic to see if there is a different hook I can employ.

@OreCruncher OreCruncher added the enhancement New feature or request label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants