Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wikidata URI json id for subject and publisher fields #3179

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

megwalt
Copy link
Contributor

@megwalt megwalt commented Oct 17, 2024

fixes #2996

Updates subject and publisher fields so that Wikidata URIs save to a resource and the appropriate labels show up on the work. The URIs already saved for the creators and scientifics fields.

Screenshots of various Wikidata URIs successfully saving to the subject and publisher fields:
Labels for an Oregon Digital resource with several labels under the Subject and Publisher fields
External URIs for Wikidata labels

Additional screenshots of the URIs saving to a creator and scientific field:
Wikidata labels for creator and scientific fields

@lamtu1 lamtu1 merged commit 4d552d2 into master Oct 18, 2024
4 checks passed
@lamtu1 lamtu1 deleted the bugfix/wikidataURILabels branch October 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Wikidata URIs in Subject Not Saved and Label Not Displayed on Existing Works
2 participants